Skip to content

Correctly handle single speed fans #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rohankapoorcom
Copy link

@rohankapoorcom rohankapoorcom commented Apr 23, 2022

This allows single speed fans to have an animated icon when they are on and sets the _step to 1 (just like a switch).

@rohankapoorcom rohankapoorcom force-pushed the animate-speedless-fans-upstream branch from 7da7230 to 2dbf190 Compare April 24, 2022 01:21
@rohankapoorcom rohankapoorcom changed the title Set the iconRotateSpeed for fans that have no speed controls Correctly handle single speed fans Apr 24, 2022
@lizsugar
Copy link

Oh wonderful! Thank you for this!

@rohankapoorcom
Copy link
Author

rohankapoorcom commented Jun 2, 2022

@lizsugar and I are maintaining a new fork. Closing this PR since it has been merged into the new fork

@rohankapoorcom rohankapoorcom deleted the animate-speedless-fans-upstream branch June 7, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants