Fix/localized slug uniqueness #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds support for changing locales in right sidebar, so the slug accurately gets updated with the localized version - tested locally, and there were no side effects happening from removing one use effect - note: this is a quick fix, it would be nice to re-factor the availability display to ensure the validation messages don't appear on locale change. I can also help with this
- added locale to the check availability function, to ensure that localized slugs can have the same path, provided they are different locales
|
@mattmilburn There is currently a bug in this branch that i'm trying to work out. I'll make a commit when I find it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.