Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions env/env.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,16 @@ var (
)

// NewEnv creates new global scope.
// The values map is created lazily on the first Define to keep scope
// creation cheap.
func NewEnv() *Env {
return &Env{
values: make(map[string]reflect.Value),
}
return &Env{}
}

// NewEnv creates new child scope.
func (e *Env) NewEnv() *Env {
return &Env{
parent: e,
values: make(map[string]reflect.Value),
}
}

Expand All @@ -80,7 +79,6 @@ func (e *Env) NewEnv() *Env {
func (e *Env) NewModule(symbol string) (*Env, error) {
module := &Env{
parent: e,
values: make(map[string]reflect.Value),
}
return module, e.Define(symbol, module)
}
Expand Down Expand Up @@ -160,11 +158,13 @@ func (e *Env) Copy() *Env {
e.rwMutex.RLock()
copy := Env{
parent: e.parent,
values: make(map[string]reflect.Value, len(e.values)),
externalLookup: e.externalLookup,
}
for name, value := range e.values {
copy.values[name] = value
if e.values != nil {
copy.values = make(map[string]reflect.Value, len(e.values))
for name, value := range e.values {
copy.values[name] = value
}
}
if e.types != nil {
copy.types = make(map[string]reflect.Type, len(e.types))
Expand Down
3 changes: 3 additions & 0 deletions env/envValues.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ func (e *Env) DefineValue(symbol string, value reflect.Value) error {
return ErrSymbolContainsDot
}
e.rwMutex.Lock()
if e.values == nil {
e.values = make(map[string]reflect.Value)
}
e.values[symbol] = value
e.rwMutex.Unlock()

Expand Down
Loading