Call VM functions directly instead of through reflect.Call - #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script-defined functions were created with reflect.MakeFunc and called with reflect.Value.Call, paying for argument frame allocation, double reflect.Value wrapping of every argument and return value, and the callReflect trampoline on every call.
Non-variadic functions with up to 4 parameters are now created as ordinary Go closures with the same structural signature that MakeFunc produced, and callExpr type-asserts to that signature and calls the closure directly. checkIfRunVMFunction, reflect.Call from Go interop, and error semantics are unchanged; variadic functions and 5+ parameters keep the MakeFunc path.
Benchmarks (AMD Ryzen 7 7735HS):
~2.6x faster on function-call heavy scripts, -69% allocations.