Update function prototype and correct linter errors#44
Open
dylannorthrup wants to merge 13 commits intomattn:mainfrom
Open
Update function prototype and correct linter errors#44dylannorthrup wants to merge 13 commits intomattn:mainfrom
dylannorthrup wants to merge 13 commits intomattn:mainfrom
Conversation
…stances where variables were declared and, on the following line, initialized
Owner
|
Sorry, Could you please fix conflicts? |
Author
Apologies for the delay. The conflicts have been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue causing build failures. It also includes a number of fixes to address warnings/errors from
golangci-lint.I've done my best to group similar changes into a single commit (i.e. "all fixes for not checking error return values in
${FILE1}" are in one commit, "fix for incorrect function prototype in${FILE1}" is in a different commit, etc).Cheers!