Fix stream --cursor not being applied to the URL#50
Merged
Conversation
u.Query() returns a copy, so mutating it via Add did not change the request URL. Encode the modified query back into RawQuery, and extract the host-building logic into streamHost with a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u.Query()returns a copy of the query values, so mutating it withAddhad no effect on the request URL and--cursorwas silently ignored. Encode the modified query back intoRawQuery, and extract the host-building logic intostreamHostso it can be covered by a unit test.