Skip to content

call value_blob/value_text before value_bytes in remaining readers#1410

Open
dxbjavid wants to merge 1 commit into
mattn:masterfrom
dxbjavid:value-call-order
Open

call value_blob/value_text before value_bytes in remaining readers#1410
dxbjavid wants to merge 1 commit into
mattn:masterfrom
dxbjavid:value-call-order

Conversation

@dxbjavid

Copy link
Copy Markdown
Contributor

the same call-order issue fixed in callbackArgString (c3e96cd) still affects callbackArgBytes and the preupdate row reader, where sqlite3_value_bytes is invoked before sqlite3_value_blob/sqlite3_value_text. per the documented safe order the count should be read after the pointer, since an internal type or encoding conversion can otherwise leave the length and the buffer describing different representations and the following C.GoBytes over-reads. reordered both blob and text branches in each to fetch the pointer first, matching callbackArgString and the column reader.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.63%. Comparing base (18cdded) to head (c93f6f6).
⚠️ Report is 100 commits behind head on master.

Files with missing lines Patch % Lines
callback.go 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   47.16%   51.63%   +4.47%     
==========================================
  Files          12       13       +1     
  Lines        1533     1867     +334     
==========================================
+ Hits          723      964     +241     
- Misses        669      742      +73     
- Partials      141      161      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants