call value_blob/value_text before value_bytes in remaining readers#1410
Open
dxbjavid wants to merge 1 commit into
Open
call value_blob/value_text before value_bytes in remaining readers#1410dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
==========================================
+ Coverage 47.16% 51.63% +4.47%
==========================================
Files 12 13 +1
Lines 1533 1867 +334
==========================================
+ Hits 723 964 +241
- Misses 669 742 +73
- Partials 141 161 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the same call-order issue fixed in callbackArgString (c3e96cd) still affects callbackArgBytes and the preupdate row reader, where sqlite3_value_bytes is invoked before sqlite3_value_blob/sqlite3_value_text. per the documented safe order the count should be read after the pointer, since an internal type or encoding conversion can otherwise leave the length and the buffer describing different representations and the following C.GoBytes over-reads. reordered both blob and text branches in each to fetch the pointer first, matching callbackArgString and the column reader.