Skip to content

fix(init): remove Unix-only stderr redirection from gh label create #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonioGassner wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(init): remove Unix-only stderr redirection from gh label create #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/windows-gh-label-stderr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ai-hero/sandcastle": patch
---

Fix `sandcastle init` crashing on Windows when creating the `Sandcastle` GitHub label. The `gh label create` invocation used a Unix-only `2>/dev/null` stderr redirection, which is not valid in PowerShell/cmd. The redirection was redundant — `execSync` already runs with `stdio: "ignore"`, which discards stderr cross-platform — so it has simply been removed with no behavior change on macOS/Linux.
2 changes: 1 addition & 1 deletion src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ const initCommand = Command.make(
yield* Effect.try({
try: () =>
execSync(
'gh label create "Sandcastle" --description "Issues for Sandcastle to work on" --color "F9A825" 2>/dev/null',
'gh label create "Sandcastle" --description "Issues for Sandcastle to work on" --color "F9A825"',
{ cwd, stdio: "ignore" },
),
catch: () => undefined,
Expand Down
Loading