Skip to content

Update the return type of match #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the return type of match #37

wants to merge 1 commit into from

Conversation

kourge
Copy link
Contributor

@kourge kourge commented Mar 14, 2017

The match function can return null if there was no match, which was documented in the JSDoc, but not in the actual return type. The error has been fixed.

@seansfkelley
Copy link

Just ran into this issue, would love for this to get released. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kourge @seansfkelley @bergerjac