fix: deploy_filename errors when no deployment.md is found.#71
Open
Josverl wants to merge 1 commit intomattytrentini:mainfrom
Open
fix: deploy_filename errors when no deployment.md is found.#71Josverl wants to merge 1 commit intomattytrentini:mainfrom
Josverl wants to merge 1 commit intomattytrentini:mainfrom
Conversation
Contributor
|
I've run into this issue myself, however it looks like the use of this property still expects it to be a path? Line 189 in d1c200e |
Contributor
Author
|
I've ran the modified versions a few hundred times across all versions of MicroPython, and found no issues. But I've been adding on as additional functionality as well, that could have hidden the issue. I'll take a look to make sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while iterating over all boards.
An
IndexError: list index out of rangeis raised when accessingdeploy_filenamefor a board that has no deploy.md( unix, windows , webassembly)