Skip to content

fix: deploy_filename errors when no deployment.md is found.#71

Open
Josverl wants to merge 1 commit intomattytrentini:mainfrom
Josverl:fix_deploy_filename
Open

fix: deploy_filename errors when no deployment.md is found.#71
Josverl wants to merge 1 commit intomattytrentini:mainfrom
Josverl:fix_deploy_filename

Conversation

@Josverl
Copy link
Copy Markdown
Contributor

@Josverl Josverl commented Feb 25, 2025

Found while iterating over all boards.
An IndexError: list index out of range is raised when accessing deploy_filename for a board that has no deploy.md

( unix, windows , webassembly)

@andrewleech
Copy link
Copy Markdown
Contributor

I've run into this issue myself, however it looks like the use of this property still expects it to be a path?

if _board.deploy_filename.is_file():

@Josverl
Copy link
Copy Markdown
Contributor Author

Josverl commented Mar 20, 2025

I've ran the modified versions a few hundred times across all versions of MicroPython, and found no issues.

But I've been adding on as additional functionality as well, that could have hidden the issue. I'll take a look to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants