Fix Docker builds for git worktrees#83
Open
andrewleech wants to merge 1 commit intomattytrentini:mainfrom
Open
Fix Docker builds for git worktrees#83andrewleech wants to merge 1 commit intomattytrentini:mainfrom
andrewleech wants to merge 1 commit intomattytrentini:mainfrom
Conversation
When building from a git worktree, the .git file contains a path to the actual .git directory. The Docker container needs access to the main .git directory to properly resolve git information and update submodules. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
07f78f6 to
5d528cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitis a file (worktree) vs directory (regular repo).gitdirectory in Docker container for worktree buildsProblem
When building from a git worktree, mpbuild fails with error:
Solution
The Docker container now properly mounts the main
.gitdirectory (e.g.,/home/user/repo/.git) instead of the worktree-specific path (e.g.,/home/user/repo/.git/worktrees/name), giving the container access to the full git repository data needed for submodule updates and version calculations.Test plan
🤖 Generated with Claude Code