Skip to content

check for frozen_manifest argument and mout parent to container #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facuver wants to merge 1 commit into
base: main
Choose a base branch
from
Open

check for frozen_manifest argument and mout parent to container #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/mpbuild/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,18 @@ def docker_build_cmd(
device_flags += "--device /dev/bus/usb/ " # USB access
for device in tty_devices:
device_flags += f"--device {device} "

user_module_volume=""
if " FROZEN_MANIFEST=" in args:
manifest = list(filter(lambda x: x.startswith("FROZEN_MANIFEST=") , extra_args))[0] .split("=")[-1]
user_module_volume = f"-v {Path(manifest).parent}:{Path(manifest).parent}"

# fmt: off
build_cmd = (
f"docker run --rm "
f"{'-it ' if docker_interactive else ''}"
f"{device_flags}" # provides access to USB and serial devices for deploy
f"-v {mpy_dir}:{mpy_dir} -w {mpy_dir} " # mount micropython dir with same path so elf/map paths match host
f"-v {mpy_dir}:{mpy_dir} {user_module_volume} -w {mpy_dir} " # mount micropython dir with same path so elf/map paths match host
f"--user {uid}:{gid} " # match running user id so generated files aren't owned by root
f"-e HOME=/tmp " # set HOME to /tmp for container
f"{build_container} "
Expand Down