Skip to content
This repository was archived by the owner on May 31, 2026. It is now read-only.

Provide a config for a homeserver with animated media support#67

Open
salixor wants to merge 1 commit into
maunium:masterfrom
salixor:feat/homeserver-based-on-mime-type
Open

Provide a config for a homeserver with animated media support#67
salixor wants to merge 1 commit into
maunium:masterfrom
salixor:feat/homeserver-based-on-mime-type

Conversation

@salixor

@salixor salixor commented Sep 12, 2023

Copy link
Copy Markdown

This provides a way to display animated media in the widget, by using a homeserver with a media repo which supports them.

It makes it possible to use one homeserver (which doesn't support such a media repo) for most of the thumbnails, and use one with support for the few animated media.

This is an optional config, which defaults to homeserver_url.

@tulir

tulir commented Sep 12, 2023

Copy link
Copy Markdown
Member

Why not just use the same one with proper thumbnailing support? 🤔

Could also not thumbnail for animated stickers, that way it works with all media repos

@LuckyTurtleDev

Copy link
Copy Markdown

Why not just use the same one with proper thumbnailing support?

This would be to easy.

@salixor

salixor commented Sep 12, 2023

Copy link
Copy Markdown
Author

The reasoning was to provide a way for people with no control over their homeserver (which may or not support such media repos) to have some configuration available to them.

Let's say their current HS supports animated thumbnails (it's nice to have them in the picker IMO) - but their HS is struggling. They switch to another one for thumbnails, but this one no longer supports animated thumbnails. They may want to display their stickers, and let the animated one load when they can.

I understand the best is to use the same HS in both cases, but having some additional configuration doesn't feel too irrational ! I'd understand if you don't want to merge it, I proposed this PR just in case it could be interesting for upstream as well o/

@YourSandwich

Copy link
Copy Markdown

Hello @salixor thank you for providing this code, I am interested in implementing this into my home server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants