Skip to content

Conversation

@mowangdk
Copy link
Collaborator

Add snapshotter to aio poc

  • Require modification to external-snapshotter

@mowangdk
Copy link
Collaborator Author

mowangdk commented Dec 2, 2025

Copy link
Owner

@mauriciopoppe mauriciopoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a POC would be good but I think we should write details about how is it that we're planning on integrating the multiple artifacts from external-snapshotter.

  • 1 unified sidecar (all the sidecar repos), 1 control plane controller, 1 webhook
  • 1 single artifact that can work in all the modes above
  • What about the snapshotter client? Do we have other sidecars with clients? If we need to make a bug fix in one client we'd need to create a new release of the monorepo even if other clients are good.

@mowangdk
Copy link
Collaborator Author

Having a POC would be good but I think we should write details about how is it that we're planning on integrating the multiple artifacts from external-snapshotter.

  • 1 unified sidecar (all the sidecar repos), 1 control plane controller, 1 webhook
  • 1 single artifact that can work in all the modes above
  • What about the snapshotter client? Do we have other sidecars with clients? If we need to make a bug fix in one client we'd need to create a new release of the monorepo even if other clients are good.

Based on our KEP, I believe1 unified sidecar (all the sidecar repos), 1 control plane controller, 1 webhook with the original design intentions.

I'd researched that VolumeAttributesClass is a built-in resource, while VolumePopulator is a vendor-defined CRD, hence they don't share a similar scenario.

And integrating the VolumeSnapshot-related client into the AIO project should be fine if it's the only client we have. what do you guys think? @ConnorJC3 @iltyty

@mowangdk mowangdk force-pushed the feature/add_snapshotters branch from b26689c to be9ff00 Compare December 14, 2025 04:56
@mowangdk
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants