Skip to content

feat: Angular v.20 update#644

Merged
mauriciovigolo merged 1 commit into
mauriciovigolo:feature/angular-v20-updatefrom
ArnaudFlaesch:feature/angular-20-update
Jun 11, 2025
Merged

feat: Angular v.20 update#644
mauriciovigolo merged 1 commit into
mauriciovigolo:feature/angular-v20-updatefrom
ArnaudFlaesch:feature/angular-20-update

Conversation

@ArnaudFlaesch

@ArnaudFlaesch ArnaudFlaesch commented May 30, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ArnaudFlaesch

ArnaudFlaesch commented May 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mauriciovigolo Hi, I created this PR to update the library with the new Angular 20, could you review this please ?

@mauriciovigolo mauriciovigolo self-requested a review June 2, 2025 07:32
@BeGj

BeGj commented Jun 2, 2025

Copy link
Copy Markdown

Looks like you have some formatting changes in the commits. Might want to remove those since they are not relevant to this pull request.

@ArnaudFlaesch

ArnaudFlaesch commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

Looks like you have some formatting changes in the commits. Might want to remove those since they are not relevant to this pull request.

Thanks, done

@BeGj

BeGj commented Jun 2, 2025

Copy link
Copy Markdown

Related issue #645

@ArnaudFlaesch

ArnaudFlaesch commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Just updated the @angular-eslint packages to v20. @mauriciovigolo Can this PR be merged ? I've been using v19 of this library with Angular 20 and it works fine, so a new version should be ok. Problem is right now i'm forced to use npm install --force just for this library so it's not convenient :(

@mauriciovigolo mauriciovigolo self-assigned this Jun 9, 2025
@mauriciovigolo mauriciovigolo added the enhancement This issue/PR is an enhancement or new feature. label Jun 9, 2025
@mauriciovigolo

mauriciovigolo commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Hi @ArnaudFlaesch,
I will release it between today and tomorrow.
Thank you for your work! 🙂

@ArnaudFlaesch

ArnaudFlaesch commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi @ArnaudFlaesch, I will release it between today and tomorrow. Thank you for your work! 🙂

Thanks a lot to you, your library is awesome :)

@mauriciovigolo mauriciovigolo changed the base branch from main to feature/angular-v20-update June 11, 2025 01:38
mauriciovigolo
mauriciovigolo approved these changes Jun 11, 2025
View reviewed changes

@mauriciovigolo mauriciovigolo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thank you @ArnaudFlaesch 💯

@mauriciovigolo mauriciovigolo merged commit 6d0a7bb into mauriciovigolo:feature/angular-v20-update Jun 11, 2025
5 of 7 checks passed
@ArnaudFlaesch

ArnaudFlaesch commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, just made a quick change here : #649 to fix the lint issue

mauriciovigolo added a commit that referenced this pull request Jun 14, 2025
@mauriciovigolo @ArnaudFlaesch
@rammba @lucagobbi @bartvanb
Feature: Support for Angular v20 and Improvements (#651)
04bb568 
* feature: Angular v.20 update (#644)

* docs: fix typos in v19 migration guide (#629)

* docs: fix incorrect migration guide URL (#639)

Co-authored-by: luca.gobbi <luca.gobbi@niuma.it>

* docs: fix add missing intercept import in README (#638)

* fix: Replace constructor parameter injection with inject() function (#649)

* feature: add a new example, improved docs and versions.

- Add a new project for fetching the configuration file hosted externally.
- Updated libraries version.
- Updated the documentation and added information about the auto refresh token feature.

---------

Co-authored-by: Arnaud Flaesch <ArnaudFlaesch@users.noreply.github.com>
Co-authored-by: Radoš Milićev <40705899+rammba@users.noreply.github.com>
Co-authored-by: Luca Gobbi <80841205+lucagobbi@users.noreply.github.com>
Co-authored-by: luca.gobbi <luca.gobbi@niuma.it>
Co-authored-by: Bart van Beusekom <bartvanbeusekom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauriciovigolo mauriciovigolo mauriciovigolo approved these changes

Assignees

@mauriciovigolo mauriciovigolo

Labels

enhancement This issue/PR is an enhancement or new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArnaudFlaesch @BeGj @mauriciovigolo