Skip to content

feature: Angular v.21 update#680

Merged
mauriciovigolo merged 1 commit into
mauriciovigolo:feature/angular-21from
ArnaudFlaesch:feature/angular-21
Dec 18, 2025
Merged

feature: Angular v.21 update#680
mauriciovigolo merged 1 commit into
mauriciovigolo:feature/angular-21from
ArnaudFlaesch:feature/angular-21

Conversation

@ArnaudFlaesch

@ArnaudFlaesch ArnaudFlaesch commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ArnaudFlaesch

ArnaudFlaesch commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the approval, there's still one test failing, I don't know why exactly. Might be worth it to replace Karma with Vitest as Karma is deprecated and Angular 21 has native support for Vitest.

@rd-wm rd-wm mentioned this pull request Nov 25, 2025
Closed
@AdrisGithub

AdrisGithub commented Nov 28, 2025

Copy link
Copy Markdown

The Test also fails on the current master Branch.

Would probably be smarter to just merge these Changes and then maybe switch to vitest in another PR.

@Masmarino

Masmarino commented Nov 28, 2025

Copy link
Copy Markdown

It will be cool to merge quickly this PR if tests also fails on main branch yes.

@no-felix

no-felix commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

@AdrisGithub #685

@ArnaudFlaesch

ArnaudFlaesch commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

@mauriciovigolo Hi, is it possible for you to review this PR (and the other one mentioned above) and possibly make a release afterwards please ?

mikem-of
mikem-of reviewed Dec 1, 2025
View reviewed changes
Comment thread package.json Outdated
@gustavomerini gustavomerini mentioned this pull request Dec 4, 2025
Closed
@mauriciovigolo mauriciovigolo self-assigned this Dec 11, 2025
@mauriciovigolo

mauriciovigolo commented Dec 11, 2025

Copy link
Copy Markdown
Owner

Hi @ArnaudFlaesch,
sorry I will dedicate some time for this PR this weekend.
Thank you for your work! 🎉

mauriciovigolo
mauriciovigolo reviewed Dec 15, 2025
View reviewed changes
Comment thread package-lock.json
mauriciovigolo
mauriciovigolo reviewed Dec 15, 2025
View reviewed changes
Comment thread projects/examples/standalone/src/app/components/home/home.component.html
<div *ngIf="copyMessage$ | async as copyMessage" class="message-box">
{{ copyMessage }}
</div>
@if (copyMessage$ | async; as copyMessage) {

@mauriciovigolo mauriciovigolo Dec 15, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

mauriciovigolo
mauriciovigolo approved these changes Dec 15, 2025
View reviewed changes

@mauriciovigolo mauriciovigolo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @ArnaudFlaesch! 💯

@ArnaudFlaesch

ArnaudFlaesch commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

Great work, @ArnaudFlaesch! 💯

Thanks :)

@mauriciovigolo mauriciovigolo changed the base branch from main to feature/angular-21 December 15, 2025 09:40
@Marcio9200

Marcio9200 commented Dec 17, 2025

Copy link
Copy Markdown

The failing CI (npm ci) looks due to an out-of-sync package-lock.json.

@mauriciovigolo

mauriciovigolo commented Dec 18, 2025

Copy link
Copy Markdown
Owner

The failing CI (npm ci) looks due to an out-of-sync package-lock.json.

#680 (comment)

@mauriciovigolo

mauriciovigolo commented Dec 18, 2025

Copy link
Copy Markdown
Owner

I will release the new version until Sunday, I updated the v21.0.0 milestone. Thanks!

@mauriciovigolo mauriciovigolo mentioned this pull request Dec 18, 2025
Closed
3 tasks
@mauriciovigolo mauriciovigolo merged commit 991ea4b into mauriciovigolo:feature/angular-21 Dec 18, 2025
4 of 5 checks passed
@Nesho-Developer

Nesho-Developer commented Dec 25, 2025

Copy link
Copy Markdown

@mauriciovigolo please release v21.0.0 milestone

mauriciovigolo pushed a commit that referenced this pull request Dec 31, 2025
@ArnaudFlaesch @mauriciovigolo
feature: Angular v.21 update (#680)
5f68be0
mauriciovigolo added a commit that referenced this pull request Dec 31, 2025
@mauriciovigolo @ArnaudFlaesch
feat: angular v21 update (#695)
cd88527 
* feature: Angular v.21 update (#680)

* chore(deps): update dependencies

---------

Co-authored-by: Arnaud Flaesch <ArnaudFlaesch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauriciovigolo mauriciovigolo mauriciovigolo approved these changes
+3 more reviewers
@jarczykkonrad jarczykkonrad jarczykkonrad approved these changes
@AdrisGithub AdrisGithub AdrisGithub approved these changes
@mikem-of mikem-of mikem-of approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mauriciovigolo mauriciovigolo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ArnaudFlaesch @AdrisGithub @Masmarino @no-felix @mauriciovigolo @Marcio9200 @Nesho-Developer @jarczykkonrad @mikem-of