Skip to content

Align keycloak typings#729

Open
kcinay055679 wants to merge 2 commits into
mauriciovigolo:mainfrom
kcinay055679:copilot/align-keycloak-typings
Open

Align keycloak typings#729
kcinay055679 wants to merge 2 commits into
mauriciovigolo:mainfrom
kcinay055679:copilot/align-keycloak-typings

Conversation

@kcinay055679

@kcinay055679 kcinay055679 commented Jun 30, 2026

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added / updated

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current typings for provideKeycloak do not allow passing a string URL as the config value, even though this usage is supported at runtime.

Issue Number: #657

What is the new behavior?

Updates the typings to allow string URLs to be used as the config value in provideKeycloak, for example:

provideKeycloak({ config: '/keycloak.json' });

Adds/updates tests to cover this behavior.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This change aligns the typings with the existing runtime behavior.

Copilot AI and others added 2 commits December 1, 2025 17:08
…lignment)

Aligns ProvideKeycloakOptions.config type with keycloak-js constructor
signature to accept both KeycloakConfig objects and string URLs pointing
to keycloak.json configuration files.

Fixes mauriciovigolo#657

Co-authored-by: DaSchTour <1907266+DaSchTour@users.noreply.github.com>
@kcinay055679

Copy link
Copy Markdown
Author

this is a one on one copy of DaSchTour#2
i tried to add the funcionality to pass an Observable (or a Promise or anything similar for that matter) but this would only make everything much more complicated, so i think just adding the URL is the most pragmatic solution, even if the pr is vibe coded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants