Skip to content

docs: Document GrapesJS Builder asset build workflow - #563

Merged
adiati98 merged 4 commits into
mautic:7.2from
Promptless:promptless/pr-16435-grapesjs-builder-assets
Jul 29, 2026
Merged

docs: Document GrapesJS Builder asset build workflow#563
adiati98 merged 4 commits into
mautic:7.2from
Promptless:promptless/pr-16435-grapesjs-builder-assets

Conversation

@promptless-for-oss

@promptless-for-oss promptless-for-oss commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Open this suggestion in Promptless to view citations and reasoning process

Documents that the GrapesJS Builder's compiled JS/CSS are no longer committed to git (mautic/mautic#16435). Adds a "Building the Builder assets" section to docs/themes/grapesjs.rst covering the gitignored dist/ directory, automatic builds on composer install/update and during initial DDEV provisioning (non-fatal when Node is missing), manual composer gjs-build / ddev gjs-build commands, the Node 24 build version, and how Parcel content-hashing plus manifest.json feed the runtime AssetsSubscriber.

@patrykgruszka review (applied)

  • Version scope: changed "From Mautic 7" to "From Mautic 7.2" — the untracked-assets build workflow ships only in 7.2, not 7.0/7.1 (confirmed against source PR #16435: base 7.x / milestone 7.2.0 / release_metadata 7.2.0-rc; the gjs-build command and dist .gitignore line are absent on 7.0.2 and 7.1.3). Applied verbatim.
  • DDEV trigger: corrected the bullet that claimed the build runs on every DDEV start. It now states the build runs when DDEV provisions the environment for the first time (not on every start), and directs existing environments to run ddev gjs-build. Applied with a minor wording refinement for parallel list structure and concision; the substance the reviewer requested is unchanged.

Trigger Events


Tip: Point @Promptless at some of your docs debt and have it clean them up in the background 🧹

The GrapesJS Builder's compiled JS/CSS are no longer tracked in git
(mautic/mautic#16435). Document that developers working from a git
checkout must build the assets, how Mautic builds them automatically
on composer install/update and DDEV bootstrap, and the manual
composer gjs-build / ddev gjs-build commands.
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst
Comment thread docs/themes/grapesjs.rst
Comment thread docs/themes/grapesjs.rst Outdated

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst
Comment thread docs/themes/grapesjs.rst
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @adiati98 — I've pushed updates addressing all the comments:

  • Feature-name capitalization — Applied the Mautic.FeatureList fixes where the word refers to the Mautic feature. Where assets refers to the built JS/CSS build artifacts (not the Mautic Asset feature), I kept the artifact meaning and cleared Vale accordingly so the text stays accurate.
  • Suggested text — Applied all three of your suggested-text replacements (Node 24 / automatic-build paragraph, the Parcel + manifest.json / AssetsSubscriber paragraph, and the git-checkout paragraph).
  • Active voice — Fixed the aren't committed passive usage and changed likesuch as.

Vale now reports no findings for this content. Ready for another look.

@adiati98
adiati98 requested a review from patrykgruszka July 10, 2026 10:13
@adiati98 adiati98 added this to the 7.2 milestone Jul 10, 2026
Comment thread docs/themes/grapesjs.rst Outdated
Comment thread docs/themes/grapesjs.rst Outdated
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @patrykgruszka — on it. We will scope the section to 'From Mautic 7.2.' and clarify that the build runs during the initial DDEV-managed setup (not on every start), directing existing environments to ddev gjs-build when needed. We will push an update to this PR shortly.

…uild trigger

- Change 'From Mautic 7' to 'From Mautic 7.2'; the untracked-assets build
  workflow ships only in 7.2, not 7.0/7.1.
- Correct the DDEV bullet: the build runs during initial DDEV provisioning,
  not on every start; direct existing environments to 'ddev gjs-build'.

@patrykgruszka patrykgruszka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @patrykgruszka! 🚀

@adiati98
adiati98 merged commit a124b99 into mautic:7.2 Jul 29, 2026
4 of 5 checks passed
@promptless-for-oss
promptless-for-oss deleted the promptless/pr-16435-grapesjs-builder-assets branch July 29, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants