docs: Document GrapesJS Builder asset build workflow - #563
Merged
adiati98 merged 4 commits intoJul 29, 2026
Conversation
The GrapesJS Builder's compiled JS/CSS are no longer tracked in git (mautic/mautic#16435). Document that developers working from a git checkout must build the assets, how Mautic builds them automatically on composer install/update and DDEV bootstrap, and the manual composer gjs-build / ddev gjs-build commands.
adiati98
requested changes
Jul 10, 2026
adiati98
left a comment
Contributor
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
Contributor
Author
|
Thanks for the review, @adiati98 — I've pushed updates addressing all the comments:
Vale now reports no findings for this content. Ready for another look. |
patrykgruszka
requested changes
Jul 29, 2026
Contributor
Author
|
Thanks @patrykgruszka — on it. We will scope the section to 'From Mautic 7.2.' and clarify that the build runs during the initial DDEV-managed setup (not on every start), directing existing environments to |
…uild trigger - Change 'From Mautic 7' to 'From Mautic 7.2'; the untracked-assets build workflow ships only in 7.2, not 7.0/7.1. - Correct the DDEV bullet: the build runs during initial DDEV provisioning, not on every start; direct existing environments to 'ddev gjs-build'.
adiati98
approved these changes
Jul 29, 2026
adiati98
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the review, @patrykgruszka! 🚀
promptless-for-oss
deleted the
promptless/pr-16435-grapesjs-builder-assets
branch
July 29, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Documents that the GrapesJS Builder's compiled JS/CSS are no longer committed to git (mautic/mautic#16435). Adds a "Building the Builder assets" section to docs/themes/grapesjs.rst covering the gitignored dist/ directory, automatic builds on composer install/update and during initial DDEV provisioning (non-fatal when Node is missing), manual composer gjs-build / ddev gjs-build commands, the Node 24 build version, and how Parcel content-hashing plus manifest.json feed the runtime AssetsSubscriber.
@patrykgruszka review (applied)
ddev gjs-build. Applied with a minor wording refinement for parallel list structure and concision; the substance the reviewer requested is unchanged.Trigger Events
Tip: Point @Promptless at some of your docs debt and have it clean them up in the background 🧹