-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixing boolean field filters in dynamic email content #14791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.x
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.x #14791 +/- ##
=========================================
Coverage 65.61% 65.61%
- Complexity 34951 34952 +1
=========================================
Files 2299 2299
Lines 140579 140583 +4
=========================================
+ Hits 92245 92248 +3
- Misses 48334 48335 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dongilbert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
… correctly.
Description
This PR fixes how boolean type custom fields render in dynamic content within the email builder. Currently, the options available for boolean fields are
0, 1
, but it should beNo, Yes
as shown in the screenshot. This PR adds a new twig filterformFieldFlipBooleanList
to address the issue.📋 Steps to test this PR: