-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Making campaign actions stats work with manual removal #14809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.2
Are you sure you want to change the base?
Making campaign actions stats work with manual removal #14809
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14809 +/- ##
============================================
+ Coverage 63.45% 63.67% +0.21%
- Complexity 34635 34662 +27
============================================
Files 2273 2273
Lines 103603 103705 +102
============================================
+ Hits 65739 66029 +290
+ Misses 37864 37676 -188
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Actions do not get Pending status if an Action before is delayed and not executed at that moment. Is it a Bug or should it be like this? (Also before the Patch) |
Description
This PR fixes the issue #14761 and makes sure the campaign action statistics work properly even when manually removing a contact via the change campaigns action

Before the campaign actions of a lead where considered just as 'pending' when the lead was manually removed from a campaign even if the actions where already executed before.
📋 Steps to test this PR: