Skip to content

Campaigns with jump to event action show incorrect data for completed actions #14837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 7.x
Choose a base branch
from

Conversation

nileshlohar
Copy link
Contributor

@nileshlohar nileshlohar commented Apr 2, 2025

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch)
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a template email.
  3. Create a segment (but don't add any contacts yet).
  4. Create a campaign. Use your segment as a source for campaign.
  5. Add Send email action to the campaign, use 3-5 minutes delay.
  6. Add Jump event action to the campaign (jump to the send email event).
  7. Publish and save the campaign. Example:
    Screenshot 2021-05-21 at 11 16 51
  8. Add a contact to your campaign. Wait 5 minutes.
  9. Open campaign view page and check Actions tab.
    Actual result:
    Screenshot 2021-05-20 at 23 44 08
    Expected result:
    Screenshot 2021-05-20 at 23 44 33

Steps to test this PR:

  1. Repeat steps 1-8 from Steps to reproduce the bug.
  2. Make sure that we see Expected result.
  3. You are free to tests other scenarios as well.

anton-vlasenko and others added 4 commits April 2, 2025 16:23
[MAUT-5805] Campaigns with jump to event action show incorrect data for completed actions
@nileshlohar
Copy link
Contributor Author

nileshlohar commented Apr 2, 2025

This is dependent on #14796
Tests should pass once that PR is merged.

@nileshlohar nileshlohar added the unforking Used for PRs in the Acquia's unforking initiative label Apr 2, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (d23467c) to head (116478d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #14837   +/-   ##
=========================================
  Coverage     65.71%   65.72%           
  Complexity    34988    34988           
=========================================
  Files          2301     2301           
  Lines        140726   140726           
=========================================
+ Hits          92484    92487    +3     
+ Misses        48242    48239    -3     
Files with missing lines Coverage Δ
...s/CampaignBundle/Controller/CampaignController.php 76.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nileshlohar nileshlohar marked this pull request as ready for review April 17, 2025 12:03
@nileshlohar nileshlohar requested review from a team, escopecz and dadarya0 and removed request for a team April 17, 2025 12:19
Copy link
Contributor

@dadarya0 dadarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unforking Used for PRs in the Acquia's unforking initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants