-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix contact device identification #14842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nileshlohar
wants to merge
5
commits into
mautic:7.x
Choose a base branch
from
nileshlohar:contact-device
base: 7.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MAUT-5773] Contact device identification fails
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x #14842 +/- ##
============================================
+ Coverage 65.61% 65.65% +0.03%
+ Complexity 34951 34949 -2
============================================
Files 2299 2299
Lines 140579 140573 -6
============================================
+ Hits 92246 92289 +43
+ Misses 48333 48284 -49
🚀 New features to boost your workflow:
|
escopecz
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues with the code changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Issues or PR's relating to bugs
code-review-passed
PRs which have passed code review
pending-test-confirmation
PR's that require one test before they can be merged
tracking
Anything related to tracking
unforking
Used for PRs in the Acquia's unforking initiative
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
📋 Steps to reproduce the issue:
Actual: Condition is false and points are deducted from the contact.
📋 Steps to test this PR:
Expected: Since the form was submitted from a Macbook, the condition should be true and points should be added to the contact.