Skip to content

Fix contradictory note about duplicate Stage weights - #774

Merged
adiati98 merged 5 commits into
mautic:7.2from
Promptless:promptless/stage-weight-unique-7.2
Jul 26, 2026
Merged

Fix contradictory note about duplicate Stage weights#774
adiati98 merged 5 commits into
mautic:7.2from
Promptless:promptless/stage-weight-unique-7.2

Conversation

@promptless-for-oss

Copy link
Copy Markdown
Contributor

Open this suggestion in Promptless to view citations and reasoning process

Corrects the "Moving Contacts between Stages" note, which incorrectly stated that multiple Stages across funnels could share the same weight. The unique-weight constraint added in mautic/mautic#15404 (and already documented in the Weight field description) makes each Stage's weight unique across all funnels. Targets the 7.2 user-docs branch.

Trigger Events


Tip: Tag @Promptless in a GitHub issue to turn it into a documentation update 🐙

The Moving Contacts note claimed multiple Stages could share the same
weight across funnels, which contradicts the unique-weight constraint
introduced in mautic/mautic#15404 and documented in the Weight field
description. Correct the note to state each Stage must have a unique
weight across all funnels.
Comment thread docs/stages/stages.rst Outdated
@escopecz

Copy link
Copy Markdown
Member

This is related to #758 resp mautic/mautic#15404

@andersonjeccel can you please check if the change is correct?

@adiati98 adiati98 added this to the Mautic 7.2 milestone Jun 25, 2026
@adiati98

adiati98 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@andersonjeccel, can you please follow up? Thanks!

@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

We double-checked this against the source change. The unique-weight constraint from mautic/mautic#15404 is a class-level UniqueEntity scoped by the weight field alone — there's no funnel, category, or project scoping — so a Stage's weight must be unique across all funnels, exactly as the corrected note now states. This is also consistent with the Weight field description added in #758.

One note for completeness: this uniqueness is enforced at the application/validation layer (no DB-level unique index), which is an app-level guarantee and appropriate for the user-facing docs. The edit reads correctly as-is.

@andersonjeccel andersonjeccel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment thread docs/stages/stages.rst Outdated
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — we're on it. We'll apply your suggested wording for the Stage weight note and push an update to this branch.

@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Update: applied your suggested wording verbatim to docs/stages/stages.rst and pushed to the branch. Ready for another look when you have a moment.

@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

@adiati98 done — applied your suggested wording verbatim to the 'Moving Contacts between Stages' note in docs/stages/stages.rst (comma after 'For example') and pushed it to the branch. The note's substance (each Stage must have a unique weight across all funnels) was already correct, so this was just the punctuation fix. Ready for another look.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/aside

Thanks for the review, @andersonjeccel! 🚀

@adiati98
adiati98 merged commit 1b6cd90 into mautic:7.2 Jul 26, 2026
3 checks passed
@promptless-for-oss
promptless-for-oss deleted the promptless/stage-weight-unique-7.2 branch July 26, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants