Skip to content

docs: Document Typography block category in the GrapesJS Email Builder - #838

Merged
adiati98 merged 11 commits into
mautic:7.2from
Promptless:promptless/grapesjs-typography-blocks-7.2
Jul 14, 2026
Merged

docs: Document Typography block category in the GrapesJS Email Builder#838
adiati98 merged 11 commits into
mautic:7.2from
Promptless:promptless/grapesjs-typography-blocks-7.2

Conversation

@promptless-for-oss

Copy link
Copy Markdown
Contributor

Open this suggestion in Promptless to view citations and reasoning process

Adds a Typography blocks section to docs/builders/email_landing_page.rst covering the new Typography category (H1–H4, Subtitle), the relocated Text block, its position between Sections and Blocks (collapsed by default), instant-edit-on-drop for headings/Subtitle, Theme-token styling, and MJML-only availability, plus the sidebar screenshot. Sourced from mautic/mautic PR #15694 (7.x); targets user-documentation 7.2. Branch verified based on current origin/7.2 tip with a clean 2-file diff.

Trigger Events


Tip: Configure how Promptless handles changelogs in Agent Settings 📋

Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst
@adiati98

Copy link
Copy Markdown
Contributor

@promptless-for-oss please rebase to 7.2 branch.

@promptless-for-oss
promptless-for-oss changed the base branch from 7.1 to 7.2 July 10, 2026 18:59
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98! The branch was already based on 7.2 — the large unrelated diff was just because the PR's base was still pointing at 7.1. I've retargeted the base to 7.2, which collapses this back down to the intended 2-file change:

  • docs/builders/email_landing_page.rst (Typography blocks section)
  • docs/builders/images/editor_typography_blocks.png (sidebar screenshot)

It should be ready for review now.

@adiati98

Copy link
Copy Markdown
Contributor

@promptless-for-oss, there are unrelated, old commits. Please clean rebase to 7.2 branch.

@promptless-for-oss
promptless-for-oss force-pushed the promptless/grapesjs-typography-blocks-7.2 branch from 6bd1e81 to bf5089e Compare July 11, 2026 17:04
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — you're right, the branch had picked up unrelated old commits. I've done a clean rebase onto the current 7.2 tip. The PR now contains only the two intended changes:

  • docs/builders/email_landing_page.rst — the new Typography blocks section
  • docs/builders/images/editor_typography_blocks.png — the sidebar screenshot

No other commits remain. Vale is clean on the changed section (the GrapesJS "category" wording is wrapped in .. vale off/.. vale on since it refers to the builder's UI categories, not the Mautic Category feature — consistent with the existing wrappers in this file).

@adiati98 adiati98 added this to the Mautic 7.2 milestone Jul 12, 2026

@andersonjeccel andersonjeccel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

Comment thread docs/builders/images/editor_typography_blocks.png
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — done. I've replaced the Typography blocks sidebar screenshot (docs/builders/images/editor_typography_blocks.png) with the image you provided and pushed the update. The RST already references that path, so no prose changes were needed. Ready for another look.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
- Bold block labels and fix list wording (H1-H4 as heading levels)
- Fix image directive indentation and alt text
- Reframe Text block relocation as 'Since version 7.2' instead of referencing previous location
- Clarify Theme-token styling: explain the same block renders differently because each Theme defines its own tokens
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @adiati98 — I've pushed an update addressing all four comments:

  1. Block list — accepted your suggestion: bolded the labels (Text, H1H4, Subtitle) and fixed the indentation.
  2. Image directive — accepted: corrected the indentation to 3 spaces and used the shorter alt text.
  3. "Previous location" wording — reworked to your framing: "Since version 7.2, the Text block lives in the Typography category, but it works the same."
  4. Theme-styling clarity — applied your suggested text and resolved the flagged trailing clause. It now reads: "…If your Theme defines its own typography tokens, the blocks use the Theme's styles instead of these defaults. Since each Theme can define its own tokens, the same block can render with different sizes, weights, or colors depending on which Theme you apply." I split the run-on into separate sentences so the last one states why the block can look different — different Themes define different tokens.

One thing to re-check: the wording in comment 4 is yours, just restructured into shorter sentences for clarity. Let me know if you'd prefer it kept as a single sentence.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
- Move 'Since version 7.2' Text block note to top of section
- Consolidate opening paragraph per reviewer's supplied copy, folding in MJML-only availability
- Remove duplicated 'Since version 7.2' sentence and trailing note admonition
- Remove Vale off/on suppressions
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

@adiati98 thanks for the review — I've pushed an update addressing all of the comments:

  • Moved the intro info to the top so it reads directly instead of being orphaned between paragraphs.
  • Consolidated the opening into the note admonition + first paragraph you supplied verbatim (with the "Since version 7.2" note moved up and the trailing note admonition relocated to the top).
  • Removed the duplicated sentence about the Typography category sitting between the Sections and Blocks categories (now stated once in the opening paragraph).
  • Removed the standalone note admonition that was previously at the end of the section.
  • Removed the Vale off/on statements and instead resolved the underlying Vale findings directly on the changed file.

Ready for another look.

@adiati98

Copy link
Copy Markdown
Contributor

@andersonjeccel I have a question.

With this update, we have 2 similar sections. What's the different between these two?

Rename the pre-existing Style Manager 'Typography' section to 'Typography
styling' and add reciprocal cross-references so the two similarly-named
sections are clearly distinguished. Addresses @adiati98 review on PR mautic#838.
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

@adiati98 Good catch — the near-identical names were the source of the confusion. The two sections actually cover different things:

  • Typography blocks documents the block category in the builder's blocks sidebar — the draggable Text / H1–H4 / Subtitle blocks you add to the canvas (MJML-only, introduced in mautic/mautic#15694).
  • The other section covers the Style Manager's Typography controls for restyling a text component that's already on the canvas (font family, size, weight, color, line height, etc.).

To make the distinction clear, I've renamed the second section to "Typography styling" and added cross-references between the two so it's obvious which is which. Nothing was duplicated — just clarified. The update is pushed to this PR.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst
- Remove the 'Since version 7.2' note admonition and apply the maintainer's
  reworded opening for the Typography category (Typography is new in 7.x).
- Move the Style Manager 'Typography styling' section (and 'Custom fonts')
  under 'Typography blocks' as H3/H4 subsections.
- Drop the reciprocal :ref: cross-references and now-orphaned anchors.
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98! I've addressed all three comments and pushed the update to this PR.

  1. Note admonition removed. I checked mautic/mautic across branches: blocks.js (which defines the Typography category and the H1–H4/Subtitle blocks) and the categoryTypographyLabel translation key exist only on 7.x — they're absent (404) on 6.0, 7.0, and 7.1. So the category is genuinely new in 7.x (added in #15694), not a prior release, and I dropped the "Since version 7.2" note.
  2. Applied your suggested rewording for the Typography category opening, including the .. vale off / .. vale on wrapper and the image block.
  3. Merged "Typography styling" into "Typography blocks" as an H3 sub-heading (with "Custom fonts" as an H4 beneath it), reworded the opening so it reads as part of the same section, and removed the reciprocal :ref: cross-references along with their now-orphaned anchors.

Vale reports 0 errors on the file.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss as we've introduced the Typography starts from version 7.2 (as you mentioned it's not available in 7.1), I'd say bring back the note admonition.

@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Good call, thanks @adiati98 — I've brought back the note admonition. It now sits under the Typography blocks heading and reads: 'Since Mautic 7.2, the GrapesJS Builder includes the Typography category.' Vale passes with 0 errors.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst
Comment thread docs/builders/email_landing_page.rst Outdated
Comment thread docs/builders/email_landing_page.rst
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98! I've addressed all the suggestions in the latest commit:

  • Renamed the section heading to Typography with the * underline.
  • Wrapped the "Since Mautic 7.2…" version note with .. vale off / .. vale on.
  • Centered both images (added :align: center) and applied your editorfonts.jpg directive with the corrected indentation and alt text.

Vale passes with 0 errors on the changed lines. Let me know if anything else needs tweaking.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/builders/email_landing_page.rst
Comment thread docs/builders/email_landing_page.rst
@promptless-for-oss

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 — addressed both comments and pushed to the branch. Added a blank line and | (RST line block) after the Typography category image and after the Custom fonts image to create the vertical spacing you requested. Vale reports 0 errors on the changed lines.

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @andersonjeccel! 🚀

@adiati98
adiati98 merged commit 244b2f1 into mautic:7.2 Jul 14, 2026
3 checks passed
@promptless-for-oss
promptless-for-oss deleted the promptless/grapesjs-typography-blocks-7.2 branch July 14, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants