docs: Document Typography block category in the GrapesJS Email Builder - #838
Conversation
|
@promptless-for-oss please rebase to 7.2 branch. |
|
Thanks @adiati98! The branch was already based on
It should be ready for review now. |
|
@promptless-for-oss, there are unrelated, old commits. Please clean rebase to 7.2 branch. |
6bd1e81 to
bf5089e
Compare
|
Thanks @adiati98 — you're right, the branch had picked up unrelated old commits. I've done a clean rebase onto the current
No other commits remain. Vale is clean on the changed section (the GrapesJS "category" wording is wrapped in |
|
Thanks @adiati98 — done. I've replaced the Typography blocks sidebar screenshot ( |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
- Bold block labels and fix list wording (H1-H4 as heading levels) - Fix image directive indentation and alt text - Reframe Text block relocation as 'Since version 7.2' instead of referencing previous location - Clarify Theme-token styling: explain the same block renders differently because each Theme defines its own tokens
|
Thanks for the review, @adiati98 — I've pushed an update addressing all four comments:
One thing to re-check: the wording in comment 4 is yours, just restructured into shorter sentences for clarity. Let me know if you'd prefer it kept as a single sentence. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
- Move 'Since version 7.2' Text block note to top of section - Consolidate opening paragraph per reviewer's supplied copy, folding in MJML-only availability - Remove duplicated 'Since version 7.2' sentence and trailing note admonition - Remove Vale off/on suppressions
|
@adiati98 thanks for the review — I've pushed an update addressing all of the comments:
Ready for another look. |
|
@andersonjeccel I have a question. With this update, we have 2 similar sections. What's the different between these two? |
Rename the pre-existing Style Manager 'Typography' section to 'Typography styling' and add reciprocal cross-references so the two similarly-named sections are clearly distinguished. Addresses @adiati98 review on PR mautic#838.
|
@adiati98 Good catch — the near-identical names were the source of the confusion. The two sections actually cover different things:
To make the distinction clear, I've renamed the second section to "Typography styling" and added cross-references between the two so it's obvious which is which. Nothing was duplicated — just clarified. The update is pushed to this PR. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
- Remove the 'Since version 7.2' note admonition and apply the maintainer's reworded opening for the Typography category (Typography is new in 7.x). - Move the Style Manager 'Typography styling' section (and 'Custom fonts') under 'Typography blocks' as H3/H4 subsections. - Drop the reciprocal :ref: cross-references and now-orphaned anchors.
|
Thanks @adiati98! I've addressed all three comments and pushed the update to this PR.
Vale reports 0 errors on the file. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss as we've introduced the Typography starts from version 7.2 (as you mentioned it's not available in 7.1), I'd say bring back the note admonition.
|
Good call, thanks @adiati98 — I've brought back the note admonition. It now sits under the Typography blocks heading and reads: 'Since Mautic 7.2, the GrapesJS Builder includes the Typography category.' Vale passes with 0 errors. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
…e, center images
|
Thanks @adiati98! I've addressed all the suggestions in the latest commit:
Vale passes with 0 errors on the changed lines. Let me know if anything else needs tweaking. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Thanks @adiati98 — addressed both comments and pushed to the branch. Added a blank line and |
adiati98
left a comment
There was a problem hiding this comment.
Thanks for the review, @andersonjeccel! 🚀
Open this suggestion in Promptless to view citations and reasoning process
Adds a Typography blocks section to docs/builders/email_landing_page.rst covering the new Typography category (H1–H4, Subtitle), the relocated Text block, its position between Sections and Blocks (collapsed by default), instant-edit-on-drop for headings/Subtitle, Theme-token styling, and MJML-only availability, plus the sidebar screenshot. Sourced from mautic/mautic PR #15694 (7.x); targets user-documentation 7.2. Branch verified based on current origin/7.2 tip with a clean 2-file diff.
Trigger Events
Tip: Configure how Promptless handles changelogs in Agent Settings 📋