docs: Document the Stage merge feature - #849
Conversation
Add a 'Merging Stages' section covering the new merge action from mautic/mautic#15399: where the action lives, the required edit and delete permissions, the merge modal and target-Stage dropdown, and a warning that the merge is irreversible (Contacts and Stage history are reassigned and the merged Stage is deleted).
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
Can you also take a screenshot of the merging stages page and add it to the docs page describing the process. The screenshot should be an example of what you see after you get it working.
… modal screenshot
|
Thanks for the review @adiati98 — I've addressed all of the feedback and pushed the updates:
I also added the requested screenshot: I ran Mautic 7.x locally, created two Stages, opened the Merging current stage modal with a target Stage selected in the dropdown, and embedded Vale passes clean on the updated section. Ready for another look. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Quick update: we've reviewed all three of your comments and confirmed the |
…enshot Addresses @adiati98's review on PR mautic#849: - Reword the permissions note and merge step to reference the Options menu opened via the three-dots icon (dropping vague 'actions menu'). - Add merge_stage_option.png screenshot after the Select Merge Stage step, with descriptive alt text.
|
Thanks for the review, @adiati98 — all three comments are addressed and pushed.
Vale is clean on the changed lines. Ready for another look whenever you have a moment. 🙌 |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Thanks, @adiati98 — following up on your latest comments. We'll fix the image indentation so it sits correctly within the ordered list, and update the image name per your note. We'll push and reply here once it's done. |
|
Update: we've mapped out all three changes — the spacer before the Options-menu screenshot, pulling the Merge Stage modal image inside the ordered list (with |
…ename - Add 'To merge Stages:' lead-in before the numbered procedure - Add a spacer before the Options-menu screenshot inside the list - Move the merge modal image inside the final step and place vale on after it - Rename merge-stage.png to merge_stage.png (underscore per review)
|
All three comments are addressed and pushed, @adiati98:
One small note on comment 2: the suggestion snippet showed the dash spelling ( Vale is clean on the changed section. Ready for another look. 🙌 |
Change 'window' to 'dialog' on the Choose-a-stage-to-merge-into step per @adiati98's suggestion on PR mautic#849, matching the repo's dominant term for AJAX modals.
|
Applied, @adiati98 — the target-Stage step now refers to the Merging current stage dialog (previously "window"), exactly as you suggested. Pushed to PR #849; Vale is clean on the changed line. One small heads-up: two nearby references in the same section still say "window" — line 94 ("...close the window without making any changes") and the |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Thanks — applying both: the Merge/Cancel step wording and the image alt-text update (aligning "window" → "dialog", as noted). Pushing the update to this PR shortly. |
Aligns the numbered step and image alt text with the 'dialog' term already used for the 'Merging current stage' dialog, per review on PR mautic#849.
|
Both applied verbatim, @adiati98 — the Merge/Cancel step and the |
|
@all-contributors please add @andersonjeccel for review. |
|
I've put up a pull request to add @andersonjeccel! 🎉 |
Open this suggestion in Promptless to view citations and reasoning process
Adds a "Merging Stages" section to the Stages page covering the new merge action from mautic/mautic#15399: where the option lives in the Stages list, the required edit and delete permissions, the merge modal and target-Stage dropdown, the confirmation message, and a warning that the merge is irreversible (Contacts and Stage change history move to the target Stage, then the merged Stage is deleted). Targets the 7.2 user-docs branch per branch-targeting rules (source PR base 7.x).
Trigger Events
Review response — @adiati98 (round 4, applied)
#. Select **Merge** to complete the merge, or **Cancel** to close the dialog without making any changes.("window" → "dialog").:alt:forimages/merge_stage.pngnow readsMerge Stage dialog with a target Stage selected("window" → "dialog").Both edits align the wording with the "dialog" term already used for the Merging current stage dialog one line above, and with the AJAX-modal implementation in mautic/mautic#15399.
Review response — @adiati98 (round 3, applied)
Choose a stage to merge intostep): applied verbatim — the step now reads#. In the **Merging current stage** dialog, use the **Choose a stage to merge into** dropdown to select the target Stage.("window" → "dialog"). This matches the repo's dominant term for AJAX modals of this kind.Review response — @adiati98 (round 2, applied)
|spacer before theimages/merge_stage_option.pngimage so it sits cleanly inside the Select Merge Stage step... vale onafter the image, and rename the file (comment 2): applied — moved the merge-modal image inside the final numbered step (indented 3 spaces with|spacers above and below) and relocated.. vale onto after that image block. The file and its reference were renamed frommerge-stage.pngtomerge_stage.png. Deviation from the literal suggestion block, on grounds: the suggestion block text still showedmerge-stage.png(dash), but the comment's own prose instruction says "We use underscore instead of dash for image name. Change the image name tomerge_stage.png." The prose instruction is authoritative, so the underscore spelling was used... vale offthat opens the procedure.Review response — @adiati98 (round 1, applied)
docs/stages/images/merge_stage_option.pngafter the Select Merge Stage step, with descriptive alt text that doesn't begin with "Screenshot of." The image directive is indented under the step so the numbered list keeps continuous 1–5 numbering.Tip: Add or adjust Promptless's style guide in Agent Knowledge Base ✍️