Skip to content

client,bridgev2: Add support for MSC4190#288

Closed
onestacked wants to merge 1 commit into
mautrix:mainfrom
ink-feather-org:msc4190
Closed

client,bridgev2: Add support for MSC4190#288
onestacked wants to merge 1 commit into
mautrix:mainfrom
ink-feather-org:msc4190

Conversation

@onestacked
Copy link
Copy Markdown
Contributor

@onestacked onestacked commented Sep 20, 2024

Adds MSC4190 support.

Copy link
Copy Markdown
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config option goes in bridgev2/bridgeconfig + bridgev2/matrix/mxmain/example-config.yaml (no need to update the legacy bridge module)

SetAppServiceDeviceID probably also has to be set in the e2ee client

@onestacked onestacked changed the title Try adding support for MSC4190 client,bridgev2: Add support for MSC4190 Sep 22, 2024
@onestacked onestacked marked this pull request as ready for review September 22, 2024 19:32
@onestacked
Copy link
Copy Markdown
Contributor Author

I've now added the config flag in bridgev2 and removed some changes not needed for bridgev2.

I've tested this with element-hq/synapse#17705 and MSC3861.
Requires msc3202_device_masquerading: true to be set in the synapse config.

Comment thread bridgev2/bridgeconfig/legacymigrate.go Outdated
@onestacked

This comment was marked as resolved.

@onestacked

This comment was marked as outdated.

@onestacked

This comment was marked as outdated.

@jkolo
Copy link
Copy Markdown

jkolo commented Dec 4, 2024

element-hq/synapse#17705 was merged into synapse develop :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants