Fix #129: Add covariant return types for builder methods#140
Open
Fix #129: Add covariant return types for builder methods#140
Conversation
…types
Element.of("foo").precedingWhitespace(" ").innerPrecedingWhitespace(" ") failed
because Node.precedingWhitespace(String) returned Node, losing the Element type.
Override precedingWhitespace(String) and parent(ContainerNode) in Element, Comment,
Text, ProcessingInstruction, and Document to return their specific type, enabling
fluent chaining in any order.
✅ CI Build PASSEDBuild Status: PASSED 🎉 All tests passed! The build is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
precedingWhitespace(String)andparent(ContainerNode)in all concrete Node subclasses (Element, Comment, Text, ProcessingInstruction, Document) to return their specific typeElement.of("foo").precedingWhitespace(" ").innerPrecedingWhitespace(" ")Test plan
precedingWhitespacebeforeinnerPrecedingWhitespaceworksCloses #129