Fix #132: Throw on invalid index in getNode and insertNode#143
Open
Fix #132: Throw on invalid index in getNode and insertNode#143
Conversation
Change getNode(int) to throw IndexOutOfBoundsException for out-of-range indices instead of silently returning null. Change insertNode(int, Node) to throw IndexOutOfBoundsException/IllegalArgumentException instead of silently ignoring invalid input. This matches standard Java collection behavior and prevents hidden bugs. BREAKING CHANGE: getNode(int) now throws IndexOutOfBoundsException instead of returning null for invalid indices. insertNode(int, Node) now throws instead of silently ignoring invalid input.
✅ CI Build PASSEDBuild Status: PASSED 🎉 All tests passed! The build is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNode(int)to throwIndexOutOfBoundsExceptionfor out-of-range indices instead of returning nullinsertNode(int, Node)to throwIndexOutOfBoundsException/IllegalArgumentExceptioninstead of silently ignoring invalid inputBREAKING CHANGE:
getNode(int)now throws instead of returning null.insertNode(int, Node)now throws instead of silently ignoring invalid input.Test plan
Closes #132