Fix #133: Rename get* methods for naming consistency#144
Open
Conversation
Rename all get* getters to match the project's no-prefix convention: - ContainerNode: getNode(int) -> node(int) - QuoteStyle: getCharacter() -> character() - Serializer: getIndentString() -> indentString() - Serializer: getLineEnding() -> lineEnding() - Serializer: getEmptyElementStyle() -> emptyElementStyle() - DomTripException: getPosition() -> position() - DomTripException: getXmlContent() -> xmlContent() Old method names are kept as @deprecated delegates for backward compatibility. BREAKING CHANGE: get* getter methods have been renamed. The old names are deprecated but still functional.
✅ CI Build PASSEDBuild Status: PASSED 🎉 All tests passed! The build is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get*getters to match the project's no-prefix convention:ContainerNode:getNode(int)→node(int)QuoteStyle:getCharacter()→character()Serializer:getIndentString()→indentString(),getLineEnding()→lineEnding(),getEmptyElementStyle()→emptyElementStyle()DomTripException:getPosition()→position(),getXmlContent()→xmlContent()@Deprecateddelegates for backward compatibilityBREAKING CHANGE:
get*getter methods have been renamed. The old names are deprecated but still functional.Test plan
Closes #133