A new record should not have descendants#7
Open
geralddzx wants to merge 1 commit into
Open
Conversation
The current behavior is that a new record will have all stories in the entire database as descendants - Rick and Gerald
shirish-pampoorickal
requested changes
Jan 27, 2017
Member
shirish-pampoorickal
left a comment
shirish-pampoorickal
left a comment
There was a problem hiding this comment.
Please add a spec to double check the behavior. Suggested changes to the subtree_conditions & sibling_conditions
| end | ||
|
|
||
| def descendant_conditions | ||
| return ["1 = 0"] if new_record? |
Member
There was a problem hiding this comment.
I don't see a spec for this?
Member
There was a problem hiding this comment.
I would suggest updating the logic around for subtree_conditions & sibling_conditions too
There was a problem hiding this comment.
Agreed - I realized we hadn't added a spec last night as I was thinking through this. Thanks for the heads up on the other areas to check!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is that a new record will have all stories in the entire database as descendants
Fixes https://github.com/mavenlink/mavenlink/pull/7412