Skip to content

move GLOBAL_POSITION_SENSOR to common#2423

Merged
hamishwillee merged 1 commit intomavlink:masterfrom
Auterion:global_position_sensor_to_common
Feb 25, 2026
Merged

move GLOBAL_POSITION_SENSOR to common#2423
hamishwillee merged 1 commit intomavlink:masterfrom
Auterion:global_position_sensor_to_common

Conversation

@haumarco
Copy link
Copy Markdown
Contributor

With the message adjustments applied in #2422, we'd now like to follow up by moving GLOBAL_POSITION_SENSOR to common.

As a use case, we have PX4/PX4-Autopilot#26307 on PX4 upstream. We want to use it as an additional interface for auxiliary global position (AGP) sources (alongside DDS) and to display AGP data on the ground control station.

Let me know what type of tests are required.

@hamishwillee
Copy link
Copy Markdown
Contributor

hamishwillee commented Feb 24, 2026

@auturgy @julianoes Any objections to merging this? The previous iteration from a few days ago was tested and is in PX4. In PX4/PX4-Autopilot#26307 it is used as and input to correct the dead reckoning estimate from known position on GCS in https://youtu.be/CMGQJNPiTJg?si=NVTHzn5PdF6h4tq0&t=1069

It is also streamed to a GCS. The message was slighlty different then, but the fundamentals of their use case were tested. I doubt they have tested every possible input source but I don't think they need to.

There is a PR to take the current version in PX4/PX4-Autopilot#26307
Note, PaulR also wants it.

If we're not happy to merge, then we need to clarify the testing regime requried.

Copy link
Copy Markdown
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion but I'm not standing in the way.

Copy link
Copy Markdown
Contributor

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this in the coordination call 👍

@hamishwillee hamishwillee merged commit 51a47ee into mavlink:master Feb 25, 2026
20 checks passed
@hamishwillee
Copy link
Copy Markdown
Contributor

Thanks for attending @haumarco and @MaEtUgR .

This was approved in https://github.com/mavlink/mavlink/wiki/20260225-Dev-Meeting

@MaEtUgR MaEtUgR deleted the global_position_sensor_to_common branch February 28, 2026 18:50
TomasTwardzik pushed a commit to Auterion/mavlink that referenced this pull request Mar 25, 2026
TomasTwardzik pushed a commit to Auterion/mavlink that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants