Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback takeoff support to the Takeoff action #12565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubenp02
Copy link
Contributor

Add fallback takeoff support to the Takeoff action

Description

Implemented a fallback for the Takeoff action for vehicles that can take off but lack guided takeoff support. The fallback action switches to the vehicle's takeoff mode and then arms it, similar to how the Start Mission action works.

Key changes:

  • Introduced a new GuidedTakeoffCapability flag to distinguish between takeoff capability and guided takeoff support.
  • Added startTakeoff method in FirmwarePlugin to switch to takeoff mode and arm the vehicle, similar to startMission.
  • Defined the takeoff flight mode for ArduPlane.
  • Updated GuidedActionsController to use the original guided takeoff action or this fallback, as appropriate.

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DonLakeFlyer
Copy link
Contributor

Implemented a fallback for the Takeoff action for vehicles that can take off but lack guided takeoff support.

Which are what exactly?

@rubenp02
Copy link
Contributor Author

rubenp02 commented Mar 20, 2025

Both PX4 and APM fixed wing A/C.

Sorry, I didn't see this before.

Implemented a fallback for the Takeoff action for vehicles that can take
off but lack guided takeoff support. The fallback action switches to the
vehicle's takeoff mode and then arms it, similar to how the Start
Mission action works.

Key changes:
- Introduced a new GuidedTakeoffCapability flag to distinguish between
  takeoff capability and guided takeoff support.
- Added startTakeoff method in FirmwarePlugin to switch to takeoff mode
  and arm the vehicle, similar to startMission.
- Defined the takeoff flight mode for ArduPlane.
- Updated GuidedActionsController to use the original guided takeoff
  action or this fallback, as appropriate.
@rubenp02 rubenp02 force-pushed the feature/add-non-guided-takeoff-action branch from 35d55a6 to 19850f9 Compare April 1, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants