regex: implement the short \N escape sequence from Perl/PCRE #5420
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `.`, Kakoune matches newlines by default. Therefore `\N` comes in very handy, as it is quicker to type than the commonly used patterns `(?S).` and `[^\n]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
., Kakoune matches newlines by default. Therefore\Ncomes in very handy, as it is quicker to type than the commonly used patterns(?S).and[^\n].\nis to\Nas\his to\H– the inverse.But this patch does not implement
\Nas a character class – instead it just creates an alias for.in(?S)mode.And, as with PCRE,
\Nis not allowed in[ ]character classes (where it would not make much sense).This way the implementation is very simple.
(Perl and PCRE additionally support the pattern '\N{U+XXX..}', which has a different meaning. Kakoune already covers this functionality by '\uXXXXXX'. So '\N' is unambiguous here.)
See also:
https://www.pcre.org/current/doc/html/pcre2pattern.html#SEC7
https://perldoc.perl.org/perlre#Character-Classes-and-other-Special-Escapes
find my Copyright Waiver in commit ab87d2b