Skip to content

Conversation

@tomoss
Copy link
Contributor

@tomoss tomoss commented Dec 5, 2025

Hello,

This follow-up PR removes the -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
argument from the Windows CI configuration.

MSVC uses a multi-config generator, so CMAKE_BUILD_TYPE is ignored and
produces a warning during configuration. The workflow already relies on
--config <type> during the build step, which is the correct approach.

Sorry for not including this cleanup in the previous PR.

@max0x7ba
Copy link
Owner

max0x7ba commented Dec 5, 2025

Thank you Ionut. I admire your attention to details.

@max0x7ba max0x7ba merged commit 5f7d697 into max0x7ba:master Dec 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants