fix(tower-sessions-core): disable parking_lot serde feature #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems unused and it slows down the compilation of all crates that depend on `parking_lot` (e.g. `tokio`). Signed-off-by: Jalil David Salamé Messina <[email protected]>
A new clippy lint was breaking CI Signed-off-by: Jalil David Salamé Messina <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 83.80% 87.28% +3.48%
==========================================
Files 5 5
Lines 352 354 +2
==========================================
+ Hits 295 309 +14
+ Misses 57 45 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unused and it slows down the compilation of all crates that depend on
parking_lot(e.g.tokio).This is technically a breaking change since feature unification means that just by adding
tower-sessions-coreas a dependencyparking_lotmutexes would be serializable. I don't know the breath of the impact though.