fix(filter): run PLTFilter last to evict PLT stubs re-added by EhFrameFilter#42
Draft
fix(filter): run PLTFilter last to evict PLT stubs re-added by EhFrameFilter#42
Conversation
…eFilter EhFrameFilter adds any FDE-confirmed address, including PLT stubs that have compiler-generated FDE records. PLTFilter must run after it so that PLT-section addresses are always evicted regardless of detection method. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
maxgio92
pushed a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DisasmDetector wraps the existing disassembly pipeline (prologue, callsite, boundary) as a CandidateDetector operating on *elf.File. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. DetectFunctionsFromELF default pipeline: detectors: [DisasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] This fixes the structural issue where a filter was emitting new candidates, creating implicit ordering dependencies. PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter regardless of pipeline order. Closes #42. Refs #43. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DisasmDetector wraps the existing disassembly pipeline (prologue, callsite, boundary) as a CandidateDetector operating on *elf.File. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. DetectFunctionsFromELF default pipeline: detectors: [DisasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] This fixes the structural issue where a filter was emitting new candidates, creating implicit ordering dependencies. PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter regardless of pipeline order. Closes #42. Refs #43. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DisasmDetector wraps the existing disassembly pipeline (prologue, callsite, boundary) as a CandidateDetector operating on *elf.File. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. DetectFunctionsFromELF default pipeline: detectors: [DisasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] This fixes the structural issue where a filter was emitting new candidates, creating implicit ordering dependencies. PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter regardless of pipeline order. Closes #42. Refs #43. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
maxgio92
added a commit
that referenced
this pull request
Mar 15, 2026
Add CandidateDetector type symmetric with CandidateFilter, and WithDetectors option symmetric with WithFilters. DetectFunctions and DetectFunctionsFromELF are both public user-facing APIs at the same level. disasmDetector (unexported) bridges between them inside the pipeline. EhFrameDetector emits CFI candidates from .eh_frame FDE records. EhFrameFilter is now a pure filter: retains only FDE-confirmed candidates and upgrades their confidence. It never appends. Default pipeline in DetectFunctionsFromELF: detectors: [disasmDetector, EhFrameDetector] filters: [CETFilter, EhFrameFilter, PLTFilter] PLT stubs introduced by EhFrameDetector are now correctly evicted by PLTFilter. Supersedes #42. Refs #43. Signed-off-by: maxgio92 <maxgio92@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EhFrameFilter adds any FDE-confirmed address, including PLT stubs that have compiler-generated FDE records. Running PLTFilter before EhFrameFilter allowed those stubs to sneak back in.
Fix: move PLTFilter to run last in the default pipeline so PLT-section addresses are always evicted regardless of how they were detected.