Conversation
39b38b1 to
9c43108
Compare
4971800 to
1aa4a9c
Compare
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds documentation for dynamic CEL-based routing rules, new OpenAPI paths and schemas for model configs and provider governance, a docs navigation entry, and a mintignore file to exclude generated OpenAPI artifacts. No runtime code or exported/public API implementations were modified. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (3 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
9c43108 to
871c05f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/providers/routing-rules.mdx`:
- Around line 875-890: The "Governance" Card in the Additional Resources block
uses a broken href (Card title "Governance" with href="/features/governance");
update that href to a valid governance page such as
"/features/governance/routing" or add an index/entry file for the
/features/governance directory so the existing link resolves, ensuring the Card
component's href points to a reachable route.
🧹 Nitpick comments (1)
docs/providers/routing-rules.mdx (1)
214-214: Clarify empty expression behavior.The documentation states: "Empty expression → Rule always matches (use
true/falsefor explicit behavior)."An empty expression always matching could lead to unintended routing behavior if a user accidentally creates a rule with an empty CEL expression. Consider documenting whether:
- Empty expressions are validated/rejected at creation time
- If allowed, whether there's a warning shown to users
- The recommended approach (using explicit
trueis mentioned, but should empty expressions be blocked?)
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@docs/mcp/filtering.mdx`:
- Around line 150-160: Update the example curl headers so they use empty header
values instead of the literal "[]"; replace the lines that show -H
"x-bf-mcp-include-clients: []" and -H "x-bf-mcp-include-tools: []" with
empty-value headers (e.g., -H "x-bf-mcp-include-clients:" and -H
"x-bf-mcp-include-tools:") because the header parser splits by comma and the
literal "[]" becomes a single token rather than an empty list.
In `@docs/providers/provider-routing.mdx`:
- Around line 1444-1449: Replace the bullet text "Capacity-aware routing: Switch
to fallback when budget/rate limits high" with a hyphenated compound adjective
and fix grammar—e.g., change the label to "Capacity-based failover" (or
"Capacity-aware failover") and update the description to "Switch to fallback
when budget/rate limits are high" so the phrase and verb agreement are correct;
locate the line containing the bullet text "Capacity-aware routing" to apply the
edit.
In `@docs/providers/routing-rules.mdx`:
- Around line 884-886: The "Governance" Card component (title="Governance")
currently states "Learn about governance layer (runs before routing rules)" but
earlier text says routing rules run before governance; update the card blurb to
reflect the correct precedence—either change the parenthetical to "(runs after
routing rules)" or rephrase to "Learn about the governance layer (applied after
routing rules determine provider selection)" so it matches the earlier sections
about routing rules executing first.
- Around line 329-334: Update the "Create Rule" response code in the docs to
match the OpenAPI spec and implementation: change the documented response from
`201 Created` to `200 OK` in the Create Rule example in routing-rules.mdx so it
matches the OpenAPI definition and the createRoutingRule implementation (which
returns the default 200); ensure the JSON example remains unchanged and the
status label text is updated to `200 OK`.
06e5f4e to
66258fa
Compare
Merge activity
|
66258fa to
41284fd
Compare
1aa4a9c to
f5e9f3f
Compare
41284fd to
0c33bbb
Compare

Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines