Skip to content

adds missing columns to migration tests#1627

Merged
akshaydeo merged 1 commit intomainfrom
02-12-adds_missing_columns_to_migration_tests
Feb 12, 2026
Merged

adds missing columns to migration tests#1627
akshaydeo merged 1 commit intomainfrom
02-12-adds_missing_columns_to_migration_tests

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Feb 12, 2026

Summary

Added new columns to database tables in migration tests to support enhanced model tracking and routing capabilities.

Changes

  • Added base_model column to governance_model_pricing table to track underlying model versions
  • Added azure_scopes column to config_keys table for Azure authentication
  • Added routing_engine_used column to logs table to track which routing mechanism was used for each request
  • Updated test data to populate these new columns with appropriate values

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Run the migration tests to ensure the new columns are properly created and populated:

# Core/Transports
go version
go test ./...

Breaking changes

  • Yes
  • No

Related issues

Supports enhanced model tracking and Azure authentication capabilities.

Security considerations

The changes enhance authentication capabilities for Azure services by adding support for scopes.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

Caution

Review failed

The head commit changed during the review from fc4bf4e to 9713d15.

📝 Walkthrough

Walkthrough

This PR enhances migration testing by introducing dynamic schema handling functions to support older database migrations. Three new utility functions conditionally generate INSERT and UPDATE statements for PostgreSQL and SQLite. An existing function is extended to extract columns from both INSERT and UPDATE statements for coverage validation. A changelog entry is reformatted.

Changes

Cohort / File(s) Summary
Migration Test Enhancement
.github/workflows/scripts/run-migration-tests.sh
Added three new functions (append_dynamic_mcp_clients_insert, append_dynamic_columns_postgres, append_dynamic_columns_sqlite) to handle dynamic column updates across older migrations. Extended extract_faker_columns to parse both INSERT and UPDATE statements for comprehensive coverage validation.
Changelog Update
transports/changelog.md
Reformatted changelog entry marker from deletion to addition; content unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops through migrations with schema in sight,
Dynamic columns now handled just right,
PostgreSQL, SQLite—both get their due,
Coverage so thorough, backward-compat too! 🌟

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 02-12-adds_missing_columns_to_migration_tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1627

@akshaydeo akshaydeo marked this pull request as ready for review February 12, 2026 16:06
@akshaydeo akshaydeo force-pushed the 02-12-adds_missing_columns_to_migration_tests branch from fc4bf4e to 9713d15 Compare February 12, 2026 16:17
@akshaydeo akshaydeo merged commit 3e3e629 into main Feb 12, 2026
7 checks passed
@akshaydeo akshaydeo deleted the 02-12-adds_missing_columns_to_migration_tests branch February 12, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant