Skip to content

feat: implement advise wrapper and update some tools scripts - #33

Merged
johnpatek merged 1 commit into
maxtek6:masterfrom
wissem01chiha:master
Sep 1, 2026
Merged

johnpatek merged 1 commit into
maxtek6:masterfrom
wissem01chiha:master

Conversation

@wissem01chiha

Copy link
Copy Markdown
Collaborator

Hi @johnpatek , i know this might be late, i have implemented the madvice wrapper motioned by @spudwa and discussed in #28, although, i didn't find a way to map the same behavior of madvice to windows api as i looked there is no extensive public API exposed by Microsoft to allow for example random, sequential, or dont_need, so they just return success without doing anything, it can be for portability goals this feature, more then behavioral abstraction, anyway,
i also added license notice on package config file .pc and updates tools scripts to work from the repo root directory , i remove the original maintainer license notice as these scripts was not part of it's copy, and introduced later by maxtek fork , the tests for advice are really for sanity and converge purpose no more can be improved , i also separated the implementation from the declaration in the page.hpp header , for clarity (i think mio api need to be reorganized ) ,
thanks very much , i hope this helps

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.12%. Comparing base (40d16fe) to head (acc101c).

Files with missing lines Patch % Lines
include/mio/page.hpp 64.28% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   78.41%   77.12%   -1.30%     
==========================================
  Files           5        5              
  Lines         139      153      +14     
  Branches       18       21       +3     
==========================================
+ Hits          109      118       +9     
- Misses         14       16       +2     
- Partials       16       19       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnpatek

Copy link
Copy Markdown
Member

Excellent work @wissem01chiha, and thank you for adding this feature along with a unit test. This looks good to me, I think we can merge it now since it doesn't seem to have any chance of breaking the existing API.

@johnpatek
johnpatek merged commit a0b3014 into maxtek6:master Sep 1, 2026
1 of 3 checks passed
@johnpatek johnpatek mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants