feat: implement advise wrapper and update some tools scripts - #33
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 78.41% 77.12% -1.30%
==========================================
Files 5 5
Lines 139 153 +14
Branches 18 21 +3
==========================================
+ Hits 109 118 +9
- Misses 14 16 +2
- Partials 16 19 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Excellent work @wissem01chiha, and thank you for adding this feature along with a unit test. This looks good to me, I think we can merge it now since it doesn't seem to have any chance of breaking the existing API. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @johnpatek , i know this might be late, i have implemented the madvice wrapper motioned by @spudwa and discussed in #28, although, i didn't find a way to map the same behavior of madvice to windows api as i looked there is no extensive public API exposed by Microsoft to allow for example random, sequential, or dont_need, so they just return success without doing anything, it can be for portability goals this feature, more then behavioral abstraction, anyway,
i also added license notice on package config file .pc and updates tools scripts to work from the repo root directory , i remove the original maintainer license notice as these scripts was not part of it's copy, and introduced later by maxtek fork , the tests for advice are really for sanity and converge purpose no more can be improved , i also separated the implementation from the declaration in the page.hpp header , for clarity (i think mio api need to be reorganized ) ,
thanks very much , i hope this helps