Add create method for CStoreVolumeReplica #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Get, List, Delete support for CStorVolumeReplicas Custom resource Signed-off-by: bharathpgp <[email protected]>
…1alpha1 insted of Openebs Signed-off-by: bharathpgp <[email protected]>
Signed-off-by: bharathpgp <[email protected]>
Signed-off-by: Bharath Natarajan <[email protected]>
Signed-off-by: Bharath Natarajan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 42.46% 42.46%
=======================================
Files 5 5
Lines 146 146
=======================================
Hits 62 62
Misses 83 83
Partials 1 1Continue to review full report at Codecov.
|
qiell
suggested changes
Oct 16, 2018
utils/k8s/openebscrd.go
Outdated
| @@ -92,20 +92,26 @@ func (k8s K8S) DeleteDisk(diskName string, opts *meta_v1.DeleteOptions) error { | |||
| return diskClient.Disks().Delete(diskName, opts) | |||
| } | |||
|
|
|||
| // GetCStorVolumeReplica returns the CStorVolumeReplica object for given CStorVolumeReplicaName and namespace | |||
| // CreateCStoreVolumeReplica creats CStoreVolumeReplica for given CStoreVolumeReplica object and namespace. | |||
There was a problem hiding this comment.
Just a minor typo fix in creates.
Rest all looks good to me.
Signed-off-by: Bharath Natarajan <[email protected]>
|
@Akash4927 can you close this, changes done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67