This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Start and end balance breakdown in activity view #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aybe-911-update-activity-view-to-show-breakdown-of-balance-changes
zachgoll
deleted the
zachgoll/maybe-911-update-activity-view-to-show-breakdown-of-balance-changes
branch
julianojulio
pushed a commit
to julianojulio/maybe-finance-maybe
that referenced
this pull request
Jul 20, 2025
* Initial data objects * Remove trend calculator * Fill in balance reconciliation for entry group * Initial tooltip component * Balance trends in activity view * Lint fixes * trade partial alignment fix * Tweaks to balance calculation to acknowledge holdings value better * More lint fixes * Bump brakeman dep * Test fixes * Remove unused class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much more intuitive experience for viewing the account "Activity View".
We now show a "reconciliation" of how we got from the start-of-day balance to the end of day balance, including "adjustments":
Future considerations
It would probably be worth adding the following fields to the
balancestable and populating them during background data syncs. This would reduce some of the complexity for these balance reconciliations; especially on days with "Valuations" where we lose information about how much of which component changed:balance.cash_change_amount- how much of the balance change came from cash movements (transactions, trades)balance.non_cash_change_amount- how much of the balance change came from holding value changes, or in the case of a non-cash Loan account, how much the balance changed from principal paydownsbalance.adjustment_amount- how much of balance change was from theValuationadjustment