Open notificaties docker compose - #1090
Conversation
fba36e9 to
ab51610
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 141 141
Lines 4712 4712
=======================================
Hits 4397 4397
Misses 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| header_value: Token ba9d233e95e04c4a8a661a27daffe7c9bd019067 | ||
|
|
||
| notifications_config_enable: true | ||
| notifications_config: |
There was a problem hiding this comment.
Nice! I think in the future (when new OZ version is released) this step can be also added to the OZ,
Btw I think this step can be also added to the ON itself, because ON subscribes to itself to check authorizations as far as I remember
But It can be done later.
There was a problem hiding this comment.
I bit the bullet and setup the complete configuration. I haven't tested it, because we don't have the new versions yet. I will try to set this up with my local branches as well actually, and verify it this way. This should be the right base we need, but minor changes might still be necessary. Also included the cloudevent configuration
There was a problem hiding this comment.
Great job! It looks nice and full, I think this is it!
I followed the steps as described in: https://open-zaak.readthedocs.io/en/stable/installation/config/openzaak_config.html More relevant docs: https://open-product.readthedocs.io/en/latest/installation/config/openproduct_config.html#configure-notificaties-api
The previous check doesn't work for docker desktop, so you can never start the services. The start commands still won't work, but I can start the desktop version manually. I asked ChatGPT for a script which checks which variant is installed, but it seems to be a bit annoying and not worth the effort.
ab51610 to
11a5cd5
Compare
annashamray
left a comment
annashamray
left a comment
There was a problem hiding this comment.
I checked that all setup_configuration steps are successfully executed
Haven't checked if the notifications really work though.
Approved, so my absence won't block you
Btw it you want to dive even deeper - here is an OZ test command to send a notification. Unfortunately I don't know if there is something similar for cloud events.
| docker compose -f openklant/docker-compose.yaml up -d | ||
| docker compose -f objecten/docker-compose.yaml up -d | ||
| docker compose -f openproduct/docker-compose.yaml up -d | ||
| docker compose -f openotificaties/docker-compose.yaml up -d |
There was a problem hiding this comment.
| docker compose -f openotificaties/docker-compose.yaml up -d | |
| docker compose -f opennotificaties/docker-compose.yaml up -d |
Oops haven't noticed typo in my first review
3 participants
Closes #1088
Dependent on #1082