add destruction check to e2e test - #1096
Conversation
…2e test In the e2e test we add the check that the task to delete a specific desctruction list has started. To do so we had to emulate celery beat schedule including it into the async test context. Celery tasks are synchronous, they include django ORM that can't be executed in async, so we had to add a sync thread for them using `sync_to_async()`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 141 141
Lines 4712 4712
=======================================
Hits 4397 4397
Misses 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
viktorvanwijk
left a comment
viktorvanwijk
left a comment
There was a problem hiding this comment.
LGTM :)
Should we document somewhere why the VCR setup doesn't work (for future references), or is that too complicated to write down neatly?
|
@viktorvanwijk couldn't make it work with async mostly and setting it up was too cumbersome for the existing e2e test classes. I also tried to convert it to a pytest, since in OAB we are moving away from django tests to pytests in terms of vcr using, but this one was too complicated for me. So can't pinpoint the single blocking issue. |
3 participants
fixes #1081