✨ [#175] link a document to a zaak - #207
Open
OlhaZahoruiko wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 77.86% 78.18% +0.32%
==========================================
Files 79 79
Lines 2665 2705 +40
Branches 154 154
==========================================
+ Hits 2075 2115 +40
Misses 557 557
Partials 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OlhaZahoruiko
force-pushed
the
feature/175-link-a-document-to-a-zaak
branch
2 times, most recently
from
June 10, 2026 12:47
998ef2d to
c6e8cd8
Compare
OlhaZahoruiko
marked this pull request as ready for review
June 10, 2026 12:49
CharString
requested changes
Jun 15, 2026
Contributor
There was a problem hiding this comment.
If you rebase onto main, you'll see a different pattern in the client you can follow.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
OlhaZahoruiko
force-pushed
the
feature/175-link-a-document-to-a-zaak
branch
from
June 16, 2026 09:41
d8b28a7 to
d053f83
Compare
CharString
reviewed
Jun 22, 2026
Comment on lines
48
to
85
| def get_items(self, params: Mapping[str, object] = {}) -> Iterable[Zaak]: | ||
| """ | ||
| Fetch all zaken using pagination, this is used for retrieving zaken for the API. | ||
| """ | ||
| data = self.make_request( | ||
| self.endpoint, | ||
| params=params, | ||
| headers=CRS_HEADERS, | ||
| parse_into=PaginatedResponseData[Zaak], | ||
| ) | ||
| return pagination_helper(self, data) # pyright: ignore[reportArgumentType] | ||
|
|
||
| def get_paginated_items( | ||
| self, params: Mapping[str, object] = {} | ||
| ) -> PaginatedResponse[Zaak]: | ||
| return self.make_request( | ||
| self.endpoint, | ||
| params=params, | ||
| headers=CRS_HEADERS, | ||
| parse_into=PaginatedResponse[Zaak], | ||
| ) | ||
|
|
||
| def get_paginated_items_by_zaaktype( | ||
| self, | ||
| zaaktype_url: str, | ||
| params: Mapping[str, object] = {}, | ||
| ) -> PaginatedResponse[Zaak]: | ||
| return self.make_request( | ||
| self.endpoint, | ||
| params={**params, "zaaktype": zaaktype_url}, | ||
| headers=CRS_HEADERS, | ||
| parse_into=PaginatedResponse[Zaak], | ||
| ) | ||
|
|
||
| def get_item_by_uuid(self, uuid: str) -> Zaak | None: | ||
| return self.make_request( | ||
| f"{self.endpoint}/{uuid}", headers=CRS_HEADERS, parse_into=Zaak | ||
| ) |
Contributor
There was a problem hiding this comment.
Right. This is the pattern I meant.
OlhaZahoruiko
force-pushed
the
feature/175-link-a-document-to-a-zaak
branch
from
June 22, 2026 12:09
2fc29fc to
35dd8ab
Compare
CharString
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175
Changes
[Describe the changes here]