Skip to content

♻️ [#28] Improve and use common actions and files - #29

Merged
svenvandescheur merged 9 commits into
mainfrom
feature/28-fix-ci-actions
Feb 24, 2026
Merged

♻️ [#28] Improve and use common actions and files#29
svenvandescheur merged 9 commits into
mainfrom
feature/28-fix-ci-actions

Conversation

@danielmursa-dev

@danielmursa-dev danielmursa-dev commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #28

  • Improve CI tests
  • Fix bug TYPE_CHECKING in accounts views
  • Fix settings in base.py, dev.py, ci.py
  • Move api settings in api.py
  • Clean some requirements from open-api-framework
  • Add SECURITY.md policy

@danielmursa-dev
danielmursa-dev force-pushed the feature/28-fix-ci-actions branch 4 times, most recently from be5b833 to d348be4 Compare February 20, 2026 13:30
Comment thread src/opendms/conf/ci.py Dismissed
@danielmursa-dev
danielmursa-dev force-pushed the feature/28-fix-ci-actions branch 2 times, most recently from 6bc9169 to 7ce1c2a Compare February 20, 2026 14:03
Comment thread src/opendms/conf/production.py Dismissed
Comment thread src/opendms/conf/production.py Dismissed
@danielmursa-dev
danielmursa-dev force-pushed the feature/28-fix-ci-actions branch 2 times, most recently from fd269b4 to f4df0b5 Compare February 20, 2026 14:36
@danielmursa-dev

danielmursa-dev commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author
  • 💥 The quick-start action fails because the index page doesn't yet exist, so it returns an error instead of a 200.
  • @svenvandescheur instead the open-api-ci / Scan docker image it fails because the codeQL is not yet activated on the repo, and I can't enable it, maybe for permissions reasons I think. For the same reason I also removed temporary the .github/workflows/code-analysis.yml workflow

@danielmursa-dev the codeql doesn't work on private repo's i think. But I feel we should keep it private until have a little more progress.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed if you're on the correct python version (3.14)?

@svenvandescheur svenvandescheur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 remark, may be ignored if incorrect, but please fix CI before merge.

@danielmursa-dev
danielmursa-dev force-pushed the feature/28-fix-ci-actions branch 2 times, most recently from fd60023 to cd35f43 Compare February 24, 2026 08:23
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@svenvandescheur
svenvandescheur force-pushed the feature/28-fix-ci-actions branch from cd35f43 to 4b35437 Compare February 24, 2026 10:26
@danielmursa-dev
danielmursa-dev force-pushed the feature/28-fix-ci-actions branch from 4b35437 to e5a9c06 Compare February 24, 2026 10:26
@danielmursa-dev
danielmursa-dev marked this pull request as draft February 24, 2026 10:29
@danielmursa-dev

Copy link
Copy Markdown
Contributor Author

@svenvandescheur All checks have been passed and conflicts have been resolved 👍

@danielmursa-dev
danielmursa-dev marked this pull request as ready for review February 24, 2026 10:35
@svenvandescheur
svenvandescheur merged commit 1425d83 into main Feb 24, 2026
21 checks passed
@danielmursa-dev
danielmursa-dev deleted the feature/28-fix-ci-actions branch March 31, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a developer I want to improve CI pipelines

4 participants