Skip to content

feat: [#2893] show the same navigation on every page - #2909

Open
pi-sigma wants to merge 1 commit into
developfrom
feat/2893-sidenav
Open

feat: [#2893] show the same navigation on every page#2909
pi-sigma wants to merge 1 commit into
developfrom
feat/2893-sidenav

Conversation

@pi-sigma

@pi-sigma pi-sigma commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Closes #2893

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.97%. Comparing base (6557389) to head (9d1be93).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2909      +/-   ##
===========================================
+ Coverage    93.96%   93.97%   +0.01%     
===========================================
  Files         1325     1326       +1     
  Lines        57243    57268      +25     
===========================================
+ Hits         53786    53820      +34     
+ Misses        3457     3448       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi-sigma
pi-sigma requested a review from swrichards September 9, 2026 13:16
@swrichards

swrichards commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Few notes (will flesh out later):

  • The registration and profile-notification page looks a bit too narrow, might need a different template
image
  • Verify missing breadcrumbs (e.g. on questions)
  • We don't currently have an "active" marker for the menu items, might be a good followup ticket.
  • Position of message banners: correct and consistent?
image
  • Actions page looks a bit crowded
image
  • Empty template?
image
  • Missing breadcrumbs on inbox:
image
  • Success message for questions not invalidated by session end
image

@lidwienl

Copy link
Copy Markdown

@pi-sigma @swrichards
Yesterday, Jiro, Nadia, and I went through all the pages to check what isn’t working correctly because of the newly added side navigation. I created a ticket for Nadia and added it to the sprint: #2924.

We also tested logging in with eHerkenning. We noticed that the side navigation is already visible while you’re still in the login process, when you still need to select a vestiging. The side navigation should only appear after you’ve selected a vestiging and are redirected to the homepage.

The same applies when switching vestiging. You’re currently taken to a screen where the side navigation is visible, but it doesn’t need to be shown there either. I noticed this was also included in Figma, so I’ll update it there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support side menu on all remaining app pages

4 participants