[#2922] Add KvK API setup configuration and cert management - #2923
Draft
swrichards wants to merge 8 commits into
Draft
[#2922] Add KvK API setup configuration and cert management#2923swrichards wants to merge 8 commits into
swrichards wants to merge 8 commits into
Conversation
bin/fetch_kvk_cert_chain.sh regenerates kvk-chain.pem from the official KVK API bundle. Pinning the chain lets it be validated and diffed independently of a code deploy.
Runs on push/PR touching the chain and weekly on a schedule, so an upcoming expiry is caught even without a code change.
Exposed as a button on the KvK config admin via the with_config_checks decorator, mirroring the openzaak fetch_cases check.
legalSubjectID/aanvrager.kvk and vestiging on the eherkenning-* test
users now match the KvK basisprofielen mock ("Test BV Donald"), so a
local eHerkenning login resolves to a company the KvK check/client can
actually look up.
Wire up a KvKConfigurationStep (api_root/api_key) and enable it for the local Docker stack, pointed at the real KvK test sandbox since no local mock exists for it.
…check Previously only hit basisprofielen. Now also calls retrieve_rsin_with_kvk, get_all_company_branches, and get_vestigingsprofiel for the first branch found, mirroring the exact sequence real login/branch-switch code paths use.
…enning oidc-eherkenning being enabled only wires up the OIDC client; the "Zakelijk" tab and eHerkenning button on the login page are gated separately by SiteConfiguration.eherkenning_enabled, which the site_config step was resetting to its False default every run.
Not used anywhere and easily confused with eherkenning-vestiging; that one already carries the same claims plus vestiging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2922.