Skip to content

feat: [#2897] expand available menu icons - #2944

Open
swrichards wants to merge 1 commit into
developfrom
2897-more-menu-icons
Open

swrichards wants to merge 1 commit into
developfrom
2897-more-menu-icons

Conversation

@swrichards

@swrichards swrichards commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

The Material Icons set is too large to offer wholesale, and inlining previews in the <select> isn't feasible since native <option> elements only render plain text. Curating the list and linking a preview page is the middle ground.

Closes: #2897


Test by creating a new draft for a CMS page > Page > Page options.

@codecov-commenter

codecov-commenter commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (4611435) to head (ddcf214).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2944   +/-   ##
========================================
  Coverage    94.00%   94.01%           
========================================
  Files         1334     1336    +2     
  Lines        57719    57806   +87     
========================================
+ Hits         54260    54347   +87     
  Misses        3459     3459           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@swrichards
swrichards requested a review from pi-sigma September 17, 2026 13:44
@swrichards
swrichards marked this pull request as ready for review September 17, 2026 13:44
The Material Icons set is too large to offer wholesale, and inlining
previews in the <select> isn't feasible since native <option> elements
only render plain text. Curating the list and linking a preview page
is the middle ground.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support broader set of NLDS icons for menu items

2 participants