Add verificatieDatum to the input and output types - #20
Merged
vaszig merged 1 commit intoSep 10, 2026
Merged
Conversation
vaszig
marked this pull request as draft
September 8, 2026 12:35
SonnyBA
requested changes
Sep 8, 2026
…t and output types
vaszig
force-pushed
the
of-6626/update-digital-address-types-with-verificatieDatum
branch
from
September 8, 2026 14:43
5bb30cb to
a50fec3
Compare
SonnyBA
approved these changes
Sep 8, 2026
vaszig
marked this pull request as ready for review
September 9, 2026 07:13
swrichards
approved these changes
Sep 9, 2026
swrichards
left a comment
swrichards
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, suggestion to add the other list params for this attribute, but if we do it'd be good to have test case, so up to you whether it's worth it for your current use-case.
Contributor
Author
|
Merging that for now since it's enough for our current situation. Since the new version of the library will need to be backported in Open Forms, we are going to do what's needed in small steps (making sure it's doable to backport smoothly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#6626
This is needed for the Open Forms issue which will make use of this field during email verification. Since the field is updated as expected via the library, I am just updating the types.