Skip to content

🔖 release 2.18.1 - #657

Merged
Floris272 merged 1 commit into
masterfrom
release/2.18.1
Sep 3, 2026
Merged

🔖 release 2.18.1#657
Floris272 merged 1 commit into
masterfrom
release/2.18.1

Conversation

@Floris272

Copy link
Copy Markdown
Contributor

upgrades notifications api common to 0.13.1

release 2.18.1

@Floris272
Floris272 requested a review from CharString September 2, 2026 14:47
@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (4e256ae) to head (72bdd5e).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   97.98%   97.98%   -0.01%     
==========================================
  Files         238      238              
  Lines       14070    14069       -1     
==========================================
- Hits        13786    13785       -1     
  Misses        284      284              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevenbal stevenbal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kevin from Den Haag mentioned that CELERY_RESULT_EXPIRES was missing, which can cause memory issues in redis, I think it'd be good to include that in this release as well maykinmedia/open-api-framework#228

Comment thread CHANGELOG.rst
Comment thread CHANGELOG.rst Outdated
Comment thread src/openklant/celery/app.py Outdated
@Floris272
Floris272 force-pushed the release/2.18.1 branch 3 times, most recently from c2ae8fa to 889a885 Compare September 3, 2026 14:59

@stevenbal stevenbal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for the changelog, looks good otherwise

Comment thread CHANGELOG.rst Outdated

**Bugfixes**

* Change notification kenmerken back to DictField instead of JSONField

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Change notification kenmerken back to DictField instead of JSONField
* [:open-klant:`656`] Change notification kenmerken back to use string values to ensure compliance with Notificaties API specification

@Floris272
Floris272 merged commit 4cd0082 into master Sep 3, 2026
31 checks passed
@Floris272
Floris272 deleted the release/2.18.1 branch September 3, 2026 16:07
@Floris272 Floris272 linked an issue Sep 4, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Klantcontact notifications fail

3 participants